Add login and signup pages #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackblanc
approved these changes
Oct 26, 2020
Member
jackblanc
left a comment
jackblanc
left a comment
There was a problem hiding this comment.
Sorry that I took so long to get back to you on this. There are a few things which could be improved but not required.
| Instance.interceptors.request.use(requestInterceptor); | ||
|
|
||
| const INVALID_ACCESS_TOKEN: string = 'Given access token is expired or invalid'; | ||
| const INVALID_ACCESS_TOKEN = 'Given access token is expired or invalid'; |
Member
There was a problem hiding this comment.
⛏️ Any reason not to have this type?
Contributor
Author
There was a problem hiding this comment.
Prettier told me to get rid of it 🤷♂️
Member
There was a problem hiding this comment.
Wait really? What was the error message?
Contributor
Author
There was a problem hiding this comment.
Something along the lines of the string type hint being unnecessary because the constant could only be a string / was obviously a string. I don't remember the exact text, unfortunately.
Member
|
thanks for making those changes, looks like there's a minor eslint issue: |
796RCP92VZ
force-pushed
the
login-signup
branch
from
0f15559 to
006430c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Monday.com Ticket
This PR includes the initial form pages for login and signup. They still need error checking, as well as updates on response from the backend (e.g. if the password is correct/incorrect, whether the values in the form are valid, etc.).
This PR
I added a login page and a signup page. This involved creating new .tsx files, creating a new interface to store the signup data, and updating the navbar/router code.
Screenshots
Provide screenshots of any new components, styling changes, or pages.
Verification Steps
I ran a local development instance with
npm start. I clicked through the pages and provided various inputs.